[clang-tidy][NFC] add comment in llvm-use-ranges for add_new_check.py #159927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) ChangesFull diff: https://github.com/llvm/llvm-project/pull/159927.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/llvm/UseRangesCheck.cpp b/clang-tools-extra/clang-tidy/llvm/UseRangesCheck.cpp
index 49dc92456af39..2c7a644b7a793 100644
--- a/clang-tools-extra/clang-tidy/llvm/UseRangesCheck.cpp
+++ b/clang-tools-extra/clang-tidy/llvm/UseRangesCheck.cpp
@@ -8,6 +8,8 @@
#include "UseRangesCheck.h"
+// FixItHint - Let the docs script know that this class does provide fixits
+
namespace clang::tidy::llvm_check {
namespace {
|
vbvictor
approved these changes
Sep 20, 2025
There was a problem hiding this comment.
LGTM, but does it matter if it already says "Yes" in "Offers fixes" in https://clang.llvm.org/extra/clang-tidy/checks/list.html?
If we re-run python script, the "yes" will disappear which is quiet annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_new_check.pydeps on heuristic method (find special words) to detect whether check support auto fix.This PR wants to add comment in
llvm-use-rangesto make it work.